• fzzzy
    oops.. power just went out at my house. good thing i have a big UPS. but i was just about to cook.
  • chuck
  • JSON_voorhees
    thanks chuck
  • JSON_voorhees
    I didn't mention it in the meeting, but I'm a little confused on how newsletterfooter is handling the newsletter form, the dialog passes a method, handleSubscribe, and the footer has some state succeeded and failed which I'm not sure how it's getting set
  • JSON_voorhees
    that's why i haven't added the ga call yet, I don't really understand how it's even working..
  • JSON_voorhees
    fzzzy: could you add some insight into how it's working?
  • fzzzy
    been a while since i looked at it, lemme check
  • fzzzy
    one sec i'm making a pr
  • JSON_voorhees
    ok thanks
  • chuck
    JSON_voorhees: i can help you there.
  • chuck
    Want to Vidyo?
  • JSON_voorhees
    I have a meeting about min vid in 4 minutes, can we right after? chuck
  • chuck
    Sure, holler when you're ready.
  • fzzzy
    small doc and cleanup pr mozilla/testpilot #2929
  • fzzzy
    JSON_voorhees: I think you want to look at actions/newsletter-form.js:newsletterFormSubscribe
  • chuck
    fzzzy: while refactoring our connects, it might make sense to make better use of this: github.com/reactjs/reselect
  • chuck
    Which we use sparingly right now.
  • fzzzy
    chuck: sounds good to me. I don't understand selectors yet but I would like to
  • chuck
    Basically memoizes state transformations for things like sorting.
  • fzzzy
    my ups is about to die, i'm going to have to find another place to work
  • chuck
    So e.g. the sort logic doesn't have to happen every time the component is rerendered, just when its results would change.
  • fzzzy
    ...or it would be nice if the power company would actually get the power back on...
  • fzzzy
    chuck: it is kind of like it manages projections of the actual redux state, right?
  • chuck
    Exactly.
  • fzzzy
    I look forward to learning more about it
  • fzzzy
    bbiab
  • chuck
    You pass it the state, the selector reduces it to what the container needs, and prevents the recalculation from happening unless it needs to.
  • chuck
    It's very simple, and has some clever APIs for composing selectors from multiple small pieces.
  • JSON_voorhees
    fzzzy: so should we ust put that ga call into that action file?
  • JSON_voorhees
    or is that mixing up concerns too much
  • JSON_voorhees
    chuck: I'm in my vidyo room
  • fzzzy
    it might be ok in that file
  • fzzzy
    JSON_voorhees: you don’t need to manually rebase prs any more since we set the default merge button to be squash
  • JSON_voorhees
    okay fzzzy that'll save me some time
  • JSON_voorhees
    old habits ;)
  • JSON_voorhees
    chuck: just realized we probably want to differentiate between the homepage "sign me up" button (email dialog) and the form in the footer
  • JSON_voorhees
    in the ga ping that is
  • JSON_voorhees
    which if we put it in the action will be a problem
  • JSON_voorhees
    id really like to refactor the email dialog to use the newletter form action as well, but that wouldn't make it in today :/
  • clouserw
    aw man, do we have to rename all our good first bugs to good first issues now? screenshots.firefox.com/o5yt8YhMn4JfGdhJ/github.com
  • clouserw
    in retrospect, it does make more sense for github. /cc chuck
  • chuck
    Bah, yeah.
  • chuck
    I'll set it up so it accepts either "help wanted" or "good first issue".
  • chuck
    It's easy enough to rename tags.
  • chuck
    clouserw: can you link me to that?
  • clouserw
    chuck: link you to what?
  • chuck
    Whatever was in that screenshot
  • lorchard
    I think that's just a thing at the top of the issues page now
  • clouserw
  • chuck
    Thanks
  • clouserw
    and it just links to the labels page or the specific labels
  • chuck
    Yeah I don't see tht.
  • clouserw
    maybe it's rolling out
  • clouserw
    I'll put a note to use Good First Issue in our meeting for next week
  • chuck
    I don't see anything here, either: github.com/blog/broadcasts
  • clouserw
  • clouserw
    doesn't say how it helps them