standups: Removed all old non-SIMD geometry types from Pathfinder 3.

wow, rude

standups: Removed all old non-SIMD geometry types from Pathfinder 3.

jdm , Thanks for the help. I'll look into it!

jdm: Thanks I'll look into it!

The succession of these flame emperors, from Shennong, the first Yan Emperor, until the time of the last Yan Emperor's defeat by the Yellow Emperor, may have been some 500 years.

pcwalton: if you have a chance to look at this: andlabs/libui #405#issuecomment-461903849

Manishearth: thanks!

So I wrote this test:

And running it under miri obviously crashed:

miri is pretty cool.

nox: nice!

hello servians :) any advise to pass the glutin's window object, instantiated in the ports, down to the player in video mediaelement

or at least the display id and gl context

vjaquez: off the top of your head do you know what the buffering behavior of proxysrc is?

also when do you need a decodebin over a plain videoconvert?

Manishearth: I have never played with proxysrc... sorry.. about decodebin, you might need to append a videoconvert after decodebin if your sink, or filter, needs a videoformat that decodebin cannot produce

normally the videodecoder determines the videoformat to generate

vjaquez: is there any reason why I can't just use videoconvert?

standups: nox/inert #5

Manishearth: where?

vjaquez: I'm getting a video or audio stream from webrtc

can I just use video/audioconvert, or must I use decodebin?

oh, ok... video/audio convert converts from one raw audio/video to another raw format

in the case of video, for example, transforming a frame con RGB to YUV

ah so you still need decodebin?

decodebin is needed when you need to decode audio/video, for examples you have H.264 and needs the raw video frames

okay

but hm with webrtc that won't be necessary unless I decide to send h264 video across

if both sides are just sending over raw video this isn't necessary, right?

decodebin is a bin with a typefinder and autoplugs a demuxer, parsers, and decoders, as required

Manishearth: right!

okay, so I'll leve it out for now

vjaquez: I'm doing the following and getting an error

let proxy_src = gst::ElementFactory::make("proxysrc", None).unwrap();

let proxy_sink = gst::ElementFactory::make("proxysink", None).unwrap();

proxy_src.set_property("proxysink", &proxy_sink).unwrap();

thread '<unnamed>' panicked at 'called `Result::unwrap()` on an `Err` value: BoolError("property can\'t be set from the given type")', src/libcore/result.rs:997:5

slomo: ^

the proxy_src element does have a "proxysink" property according to the docs and gst-inspect-1.0

mmmhh... perhaps you need to downcast it

since the factory::make delivers a GstElement

hm

and the property request a GstProxySink

oh, downcast the sink?

hrm

you can't downcast it :)

and it shouldn't be necessary either

upcast it? :S

downcast would be the correct direction :)

and why the &?

to make it a trait object

let me write a testcase, i think this is a bug in glib :) but first lunch

(glib bindings)

this is what we have to do in player github.com/servo/media/blob/master/…ckends/gstreamer/src/player.rs#L404

to set the appsink in glsinkbin

no, the cast there is needed so you can use the appsink API on it

that's not needed for setting it on that property

and line 437 can be without the "to_value()" :)

and 425

but lunch, bbl

fwiw I'm basically copying philn's code here: github.com/WebKit/webkit/compare/ma…e3d7b4cd5f6fc9792616744354f5f6dR589

oh maybe the ToValue impl requires a cst

I can't cast to a ProxySink though

Value("(GstProxySink) proxysink0")

that's the value that gets created

which is correct

don't worry about debugging this for now, i'm on it :)

get_property_type returns Some(GstProxySink)

the checks in glib are too strict, that's the problem :) i'm preparing a PR

ah nice

slomo: anything I can do in the meantime?

slomo: while I was reading it I came across a comment making me think so, but I wasn't sure

(there's a comment in set_property saying that it's stricter to be more Rusty)

yes but it's actually too strict :)

but in this case I have a Value of type GstProxySink

in C you could set a u32 on a i32 property for example, that's something we want to prevent

ah

they do say they allow subtypes

and into_value() correctly subtypes the gst::Element into a GstProxySink

the problem here is that the GValue has a type for GstElement, but the contained object is a GstProxySink

and we check the type of the GValue, and not the type of the contained object

slomo: it doesn't though

I did println!("{:?}", sink.into_value())

Value("(GstProxySink) proxysink0")

is what i got

oh

print sink.to_value().type_() :)

to_value_type returns GstElement

gah

okay gtg

any way to downcast the value?

so that i don't have to wait for a fix?

not without unsafe code. but if you have to leave now anyway, expect it to be fixed in the next hour or two :)

gtg == got to go i assume?

yeah

thanks!

Manishearth: btw feel free to join #servo-media :)

philn: oo nice

nox: servo/servo #22767 anything new there ?

eijebong: 302 jdm

nox: 404 jdm not found

nox: soc/dirs-rs 4dbc234#commitcomment-32410311 Getting rand 0.4 and 0.5 out once this is released :)

eijebong: thanks for the PR, just FYI I can't update ipc-channel in crates.io, so in order to use it someone will need to publish the update

dlrobertson: No problems, I've got publish rights ;)

eijebong: +1 awesome, just wanted to make sure you weren't waiting on me

500 jdm error: meant to be on PTO

issue closed as [go visit MOMA, josh]

do we have any mozilla employees who are particularly versed in the intersection of windows code and rust?

TIL about crates.io/crates/lifeguard

Oooh, lifeguard is almost exactly what I want, but it has RcRecycled rather than ArcRecycled :/

ajeffrey: I like the name x)

eijebong: I'm trying to decide submitting a PR to get ArcRecycled, or just use a simple pool that does the thing I want: play.rust-lang.org/?version=stable&…st=7087b5b2325af5142f38a9580e74a722

ajeffrey: What happens when values are dropped ? They're not removed from the pool, right ?

eijebong: that's the idea, they can then be recycled from the pool.

ajeffrey: How do you find them back ?

eijebong: pool.remove()

returns a Some(val) if it can recycle from the pool, and None otherwise.

OH

eijebong: Arc is clever.

standups: got sink stuff working again, but there's latency

standups: sink code fixes pushed up at servo/media #208

froydnj: acrichto is the most well-versed staff member. WindowsBunny is the person on IRC I usually bug with my Windows+Rust questions :-)

meanwhile larsberg is the person whose house I usually bug

I have so much pre-release/developer preview VR and AR hardware in my room that bunny-bugs are the least of my worries :-)

Manishearth: do you see a problem with making rust-webvr-api depend on gleam?

(I'm trying to fix servo/rust-webvr #61)

ajeffrey: nope

Manishearth: kewl

Believe it or not, this is a step forwards... irccloud.mozilla.com/file/1sMw3Def/…02019-02-21%20at%201.34.17%20PM.png

Servo's now drawing something in the VRDisplay window,

it's just not meant to be all red :/

standups: Yesterday, improved the rendering of strokes in Pathfinder 3. Today, fixing various bugs.

standups: Back to GL plumbing for WebVR.

My life as a plumber: servo/rust-webvr #61#issuecomment-466143411

ajeffrey: You training for the release of Super Mario Maker 2?

nox: I wish.

Ah, my favourite source of deadlock, ipc channel send is blocking.

Past me even wrote a somewhat passive-agressive note about this: github.com/servo/servo/blob/0dda115…stellation/constellation.rs#L80-L90