-
ghservo
[servo] emilio opened pull request #20617: Enforce rustfmt on automation. (master...rustfmt)
git.io/vxb28
-
emilio
bholley: Manishearth: What about something like ^?
-
Manishearth
emilio: hmmmmm
-
Manishearth
emilio: sounds like it could be fragile, but if it works ... !
-
ghservo
[webrender] glennw opened pull request #2641: Use a freelist to store render task cache entries, make cache entry public. (master...rt-prep)
git.io/vxb2u
-
Manishearth
I'm wary of this being annoying to contributors but idk
-
Manishearth
(as opposed to just pushing on "rustfmt everything")
-
emilio
Manishearth: well, the problem with pushing on "rustfmt everything" is that as soon as other people land code without using rustfmt it's useless
-
emilio
Manishearth: probably we shouldn't land that as-is though, probably should at least warn on test-tidy or what not
-
emilio
Manishearth: which is blocked on the `rustfmt` "check" stuff.
-
Manishearth
emilio: no I mean that we CI-check rustfmt everything
-
emilio
Manishearth: that basically means that whenever rustfmt changes anything CI is broken
-
emilio
Manishearth: which is not acceptable
-
Manishearth
emilio: use the pinned-nightly rustfmt
-
emilio
Manishearth: (IMO, at least :P)
-
Manishearth
./mach fmt
-
emilio
Manishearth: sure, but then you need to periodically update it
-
Manishearth
*shrug*
-
Manishearth
emilio: either way, please provide a mach command so that folks can easily run this step locally
-
emilio
Manishearth: sure, sure, that's not intended to be mergeable as-is
-
Manishearth
sgmt
-
ghservo
[servo] emilio opened pull request #20618: See if #20617 works. (master...rustfmt-smoketest)
git.io/vxba0
-
emilio
nrc: fyi #20617 is my proposal for doing rustfmt CI on servo
-
crowbot
PR #20617: [WIP RFC] Enforce rustfmt on automation. -
servo/servo #20617
-
ghservo
[servo] bors-servo closed pull request #20603: Run rustfmt on selectors, servo_arc, and style (master...rustfmt_style)
git.io/vxdYS
-
ghservo
[webrender] bors-servo merged auto into master:
git.io/vxbPd
-
ghservo
[webrender] bors-servo closed pull request #2641: Use a freelist to store render task cache entries, make cache entry public. (master...rt-prep)
git.io/vxb2u
-
ccoroiu|sheriffduty
emilio: these
-
ccoroiu|sheriffduty
-
ccoroiu|sheriffduty
ctedJob=172996817 are fixed by be94036426d7?
-
ccoroiu|sheriffduty
-
Paul
how do I run one unit test with mach? I want to run components/net/tests/cookie.rs
-
Paul
./mach -v cargo test does it
-
Paul
./mach cargo test-unit works. I was trying with ./mach cargo test unit
-
ghservo
[servo] upsuper opened pull request #20619: Have nscssproperty a method of data instances (master...properties-data)
git.io/vxbSp
-
xidorn
hmm... pointer cannot be type of global static?
-
xidorn
oh, it can. I mean, type of const
-
ghservo
[webrender] mrobinson opened pull request #2642: Improve border dot handling for small radii (master...border-dots)
git.io/vxbdZ
-
ghservo
[servo] emilio opened pull request #20620: style: Simplify ImageValue. (master...imagevalue)
git.io/vxbF6
-
Paul
SimonSapin: is incremental compilation a lot faster? Just realized how much space it takes on my disk. Not sure if it's worth it or not.
-
xidorn
why "static XXX: *const Type" doesn't work but "static mut XXX: *const Type" works...?
-
eijebong
-
nox
xidorn: What do you mean?
-
xidorn
nox: you can see #rust channel for more
-
emilio
Paul: if it's not you should talk to mw on #rustc :P
-
nox
emilio: Somehow I don't see Josh's bot do the WPT sync PRs anymore -.-
-
nox
I hope I didn't break the hell out of it.
-
eijebong
nox: Speaking of breaking bots, have you seen my PR ? :p
-
nox
eijebong: Which one?
-
eijebong
-
crowbot
PR #20611: Dedupe syn, quote and unicode-xid -
servo/servo #20611
-
ghservo
[webrender] mrobinson opened pull request #2643: Collect Renderer VAOs into a structure to simply passing them (master...vao-struct)
git.io/vxNTR
-
ghservo
[servo] emilio opened issue #20621: [cssom] getComputedStyle and shorthands
git.io/vxNTy
-
ghservo
[servo] emilio closed issue #20621: [cssom] getComputedStyle and shorthands
git.io/vxNTy
-
ghservo
[servo] bors-servo closed pull request #20620: style: Simplify ImageValue. (master...imagevalue)
git.io/vxbF6
-
SimonSapin
Paul: "a lot" really depends, try disabling it with `CARGO_INCREMENTAL=0` and see
-
SimonSapin
IMO space on a disk paid by mozilla is much cheaper than my time
-
ghservo
[rust-mozjs] marmistrz opened pull request #422: Create a second set of borrowing wrappers (master...wrappers2)
git.io/vxNm5
-
marmistrz
nox, review please ^ :)
-
nox
marmistrz: Ack, will review soon.
-
yasser
hello
-
yasser
wanted to help with rust-bindgen
-
yasser
-
yasser
which issue should i pick up?
-
nox
emilio: I wonder if you should have created a FFI WG for bindgen,
-
nox
you get your workgroup, she gets her workgroup, everyone gets their workgroup.
-
emilio
nox: lol
-
eijebong
nox: I want a dependency updating workgroup
-
emilio
nox: just became editor of the CSSOM spec, don't ask
-
nox
:O
-
nox
emilio: NICE
-
nox
emilio: So you can't hack on Mosaic anymore? :(
-
emilio
nox: looks like it
-
qweo
emilio, you actually hack on Mosaic?
-
emilio
qweo: lol nope
-
emilio
qweo: nox is just french :)
-
nox
Ah ah.
-
qweo
It runs on modern systems, so I thought maybe it required porting and whatnot
-
qweo
Joke is lost on me though
-
nox
qweo: For once unrelated to my Frenchness, to be fair.
-
nox
qweo: It's just that emilio happens to also have some commits in Webkit and Blink,
-
nox
qweo: so I once joked he also has push rights to Edge, and Opera, and Mosaic,
-
nox
and even Tim Berners-Lee's genome.
-
qweo
Was WWW the original browser ever open-sourced by the way?
-
qweo
Which engine is easier to hack on? You'd likely say "Servo", so the next-best is interesting too
-
nox
emilio: ^
-
nox
qweo: Servo is the only one in Rust, all the others are in C++, so all the others are significantly harder to contribute to, IMO.
-
fabrice
blink is stupidly massive
-
fabrice
if you like wrappers, you'll like it
-
qweo
Significantly more so than WebKit and Gecko?
-
emilio
qweo: Yeah, blink's build-time is terrible.
-
emilio
qweo: I'd say Servo -> Gecko -> WebKit -> Blink
-
emilio
qweo: however I like WebKit's code style much better than Gecko's and Blink's
-
qweo
Which aspects of it? Not mere formatting I presume?
-
nox
Not being >20 years old help.
-
emilio
nox: well, sure. Blink is a fork though, and I still like it more
-
nox
emilio: True.
-
emilio
qweo: mostly conventions... the code style generally feels cleaner, I dislike gecko's aFoo for arguments and such, and blinks combination of snake_case and CamelCase
-
qweo
why_is_it_called_snake_case_by_the_way?
-
nox
Because ____ is a snake on the ground.
-
nox
snake🐍case
-
qweo
Is there a crossed-out camel emoji? :-)
-
nox
-
ghservo
[servo] coypoop opened pull request #20622: Fix build with __uint32_t etc. not found errors on NetBSD/amd64 (master...master)
git.io/vxNWy
-
qweo
Twitter "UX" when openned in a text browser is attrocious
-
nox
qweo: There is no such thing as text browser.
-
qweo
Text-mode. And there is, if you want to call pager a text browser :-)
-
eijebong
nox: What about baguette🥖case ?
-
nox
eijebong: It's not an established casing scheme.
-
eijebong
because kebab case is one . o_o
-
eijebong
?
-
nox
Yes it is.
-
nox
It's-with-dashes.
-
nox
Pretty popular in Lisps.
-
eijebong
Oh ok...
-
nox
eijebong: Think the meat on the spinning thingie.
-
eijebong
"meat"
-
nox
It's meat.
-
ghservo
[servo] nox opened issue #20623: Properly check the argument of WebGLRenderingContext.clear
git.io/vxNRW
-
nox
emilio: "If first is negative, an INVALID_VALUE error will be generated."
-
nox
emilio: next method: "in addition the offset must be non-negative or an INVALID_VALUE error will be generated"
-
nox
Y U NO WRITE IT THE SAME WAY
-
emilio
nox: lol
-
ghservo
[webrender] nical opened pull request #2644: Use the brush shaders for repeated images/gradient in some cases. (master...brush-repeat-enable)
git.io/vxNEQ
-
emilio
xidorn: I'm cssom editor now lol
-
xidorn
emilio: oh? wg just resolved something there?
-
emilio
xidorn: yup!
-
xidorn
emilio: cong :)
-
emilio
xidorn: well, CSSOM seems like a can of worms
-
xidorn
emilio: you should push a commit to add yourself into the list first
-
emilio
xidorn: but hopefully now I can do something about it
-
emilio
xidorn: fair enough :)
-
nox
-
emilio
nox: lol @ hair model
-
nox
emilio: Speaking the truth.
-
nox
emilio: Maybe that's why you work on hairy code.
-
emilio
nox: worse so far, and the bar was already low :D
-
nox
emilio: I'm a limbo dance god.
-
emilio
hah
-
cbrewster
ajeffrey: r? #20579
-
crowbot
PR #20579: Replace initial about:blank loads -
servo/servo #20579
-
nox
bholley, emilio, SimonSapin:
rust-lang/rust #49879
-
crowbot
Issue #49879: Implement cross-language ThinLTO -
rust-lang/rust #49879
-
nox
(Issue, not PR, unfortunately. :P)
-
bholley
nox: \o/
-
bholley
nox: k17e mentioned yesterday he was going to have mw look into it
-
nox
k17e?
-
nox
Oh, I think I know who you mean.
-
nox
Or not, confused myself with a Japanese Erlang dev.
-
bholley
kentuckyfriedtakahe
-
bholley
Anthony Jones
-
nox
Hah.
-
bholley
(mw's manager)
-
nox
bholley: Ack.
-
ghservo
[webrender] bors-servo merged auto into master:
git.io/vxNyn
-
ghservo
[webrender] bors-servo closed pull request #2643: Collect Renderer VAOs into a structure to simplify passing them (master...vao-struct)
git.io/vxNTR
-
ajeffrey
avadacatavra: are you the right person to ask about anything to do with metrics?
-
ajeffrey
I'm failing to work out this test failure:
servo/servo #20579#issuecomment-380501491
-
crowbot
PR #20579: Replace initial about:blank loads -
servo/servo #20579
-
ghservo
[webrender] fschutt opened issue #2645: webrender does not compile on Windows with feature=pathfinder
git.io/vxNQt
-
ghservo
[euclid] nical opened pull request #287: Add BoolVector2D/3D. (master...bvec)
git.io/vxNQR
-
ajeffrey
-
ajeffrey
-
ajeffrey
it looks like if the first-paint is received before the first-contentful-paint then two first-paint events will be generated (which would explain the test failure).
-
ajeffrey
cbrewster: ^
-
avadacatavra
ajeffrey: the paint time metrics were written by ferjm iirc but he's out
-
avadacatavra
so i would double check spec and then i can r the pr
-
ajeffrey
avadacatavra: OK
-
avadacatavra
just because i'm not familiar with the paint time part at all and seems like you might have already figured out the problem :)
-
» avadacatavra disappears for 2 hours
-
ajeffrey
-
ghservo
[servo] asajeffrey opened issue #20624: No spec links in metrics/lib.rs
git.io/vxNdU
-
ajones
bholley: the plan is to figure out exactly what needs to happen, then figure out how to make it happen
-
ajones
inlining between C++/Rust will require clang which is currently 5-10% slower than msvc
-
ajones
but hopefully the same inlining will reduce the gap between msvc and clang
-
ajeffrey
standups: trying to track down test failure in performance metrics, which is blocking session history cleanup.
servo/servo #20579#issuecomment-380501491
-
crowbot
PR #20579: Replace initial about:blank loads -
servo/servo #20579
-
standups
Ok, submitted #56586 for
standu.ps/user/ajeffrey
-
ghservo
[webrender] Gankro opened pull request #2646: add reftest for mask clips on stacking contexts, closes #1957 (master...test-masking)
git.io/vxNjV
-
ghservo
[servo] bors-servo closed issue #14720: Iframes always load with about:blank in history
git.io/vMftJ
-
203AAV1T1
[servo] bors-servo closed pull request #20579: Replace initial about:blank loads (master...about_blank_replace)
git.io/vxHVZ
-
ghservo
[servo] asajeffrey opened issue #20625: Intermittent fail in /_mozilla/mozilla/paint_timing.html
git.io/vxAky
-
ajeffrey
cbrewster: #20579 landed \o/
-
crowbot
PR #20579: Replace initial about:blank loads -
servo/servo #20579
-
cbrewster
ajeffrey: \o/
-
ajeffrey
standups: Filed issue #20625: Intermittent fail in /_mozilla/mozilla/paint_timing.html
-
crowbot
Issue #20625: Intermittent fail in /_mozilla/mozilla/paint_timing.html -
servo/servo #20625
-
standups
Ok, submitted #56590 for
standu.ps/user/ajeffrey
-
ajeffrey
cbrewster: yay, about:blank is a bit less horrible!
-
cbrewster
ajeffrey: I’ve been wanting that fix for quite a while now
-
ajeffrey
cbrewster: me too!
-
ghservo
[webrender] bors-servo merged auto into master:
git.io/vxAqK
-
ghservo
[webrender] bors-servo closed issue #1957: Image masks don't create an intermediate surface to group the masked contents
git.io/vFkYZ
-
ghservo
[webrender] kvark opened pull request #2647: Error on missed pipeline DL (master...pipeline-error)
git.io/vxAYU
-
ghservo
[webrender] Gankro opened pull request #2648: stop using bare println (master...kill-all-prints)
git.io/vxAYk
-
ghservo
[webrender] staktrace opened pull request #2649: Add a frame message to append dynamic properties. (master...append)
git.io/vxAYd
-
ghservo
[servo] bors-servo closed pull request #20619: Have nscssproperty a method of data instances (master...properties-data)
git.io/vxbSp
-
ajeffrey
standups: Created github repo for work on speculative evaluation
github.com/chicago-relaxed-memory/spec-eval
-
standups
Ok, submitted #56592 for
standu.ps/user/ajeffrey
-
ghservo
[gleam] kvark tagged v0.0.4.32 at auto:
git.io/vxA3Y
-
ghservo
[webrender] kvark opened pull request #2650: Echo driver debug messages (master...echo-debug)
git.io/vxA3D
-
ghservo
[rust-mozjs] vyv03354 opened pull request #423: Require C++14 (master...patch-1)
git.io/vxA3N
-
avadacatavra
-
ajeffrey
avadacatavra: do we need stuff that isn't in
w3c.github.io/performance-timeline ?
-
avadacatavra
afaik time to interactive and paint metrics are part of progressive web metrics
-
avadacatavra
which i'm not sure has been standardized yet
-
-
crowbot
Issue #4720: first meaningful paint is inaccurate -
GoogleChrome/lighthouse #4720
-
ajeffrey
-
ajeffrey
avadacatavra: ^
-
avadacatavra
ajeffrey: ah yeah that looks more official :p
-
eijebong
Oh btw, I'll need help with #20611 :/ That's a loooooot of failing tests
-
crowbot
PR #20611: Dedupe syn, quote and unicode-xid -
servo/servo #20611
-
ajeffrey
avadacatavra: and the rather less official
github.com/WICG/time-to-interactive
-
avadacatavra
ajeffrey: i still don't see a better link for tti
-
avadacatavra
ajeffrey: agreed
-
avadacatavra
pr incoming shortly :)
-
ghservo
[servo] avadacatavra opened pull request #20626: added spec comments for progressive web metrics (master...pwm-spec)
git.io/vxAn9
-
ghservo
[servo] KiChjang closed issue #18328: Intermittent failure in /_mozilla/mozilla/getBoundingClientRect.html
git.io/v58z0
-
ghservo
[servo] KiChjang reopened issue #18328: Intermittent failure in /_mozilla/mozilla/getBoundingClientRect.html
git.io/v58z0
-
ajeffrey
standups: Attended meeting on personal agents (with my angle being MR security).
-
standups
Ok, submitted #56596 for
standu.ps/user/ajeffrey
-
ghservo
[webrender] glennw closed pull request #2631: appveyor: download latest stable rust with rustup (master...appveyor)
git.io/vxQsD
-
KiChjang
ajeffrey: "personal agents"?
-
KiChjang
pardon me but that sounds like something that's taken directly out of a 007 movie
-
ajeffrey
KiChjang: think Cortana
-
KiChjang
ohhh
-
ajeffrey
KiChjang: with my security hat on, I'm thinking "trust anchor".
-
KiChjang
we are slowly pacing towards the future that megaman battle network paints
-
ajeffrey
so if your immersive reality says "honest I'm your bank", you have less reason to believe it than if your personal agent introduces you.
-
KiChjang
where users navigate the virtual online world with a NetNavi
-
KiChjang
ohh, interesting stuff
-
KiChjang
so it can play both roles i believe?
-
KiChjang
both authentication of the user
-
KiChjang
and the website being visited
-
ghservo
[servo] bors-servo closed issue #20624: No spec links in metrics/lib.rs
git.io/vxNdU
-
ghservo
[webrender] bors-servo closed pull request #2647: Error on missed pipeline DL (master...pipeline-error)
git.io/vxAYU