• ghservo
    [rust-bindgen] tamird opened pull request #1157: Generate ptr::null rather than zero literal (master...use-ptr-null) git.io/vFH4h
  • cybai_
    emilio: Thanks :D
  • ghservo
    [servo] CYBAI opened pull request #19282: Use macro to impl From for font variant (master...use-macro-for-font-variant) git.io/vFHBQ
  • KiChjang
    woo, we're gonna get cached HTTP requests
  • fwiw
    yay
  • jdm
    matthias1rgr: that's a very weird error for fedora
  • jdm
    matthias1rgr: since task_info is only used on macos
  • jdm
  • jdm
  • » jdm goes back to weekending
  • KiChjang
    gotta love the sudden jdm at the weekends
  • tigercosmos
    Is it possible to write a bot that user can add labels on issue by themselves
  • KiChjang
    tigercosmos, you're saying that we should extend the functionality of highfive?
  • KiChjang
    it does add labels in a limited way nowadays
  • KiChjang
    if you say @highfive assign me, it'll add a C-Assigned label
  • tigercosmos
    It seems only issue with "easy" assign me will work?
  • tigercosmos
    I know jdm work hard on looking at issues, but some issue still have no labels. (But I know what label it should be)
  • tigercosmos
    maybe let contributor add first, and members double check later?
  • KiChjang
    tigercosmos, you'll need repo access in order to assign labels
  • KiChjang
    given that we have increased spamming activity nowadays, it's rather difficult to introduce such a feature
  • tigercosmos
    Another way if via highfive?
  • est31_seen_a_bunny_today
    Manishearth: iron/urlencoded #68 ???
  • crowbot
    Issue #68: Version bump for Serde? - iron/urlencoded #68
  • Manishearth
    est31_seen_a_bunny_today: it was solved?
  • est31_seen_a_bunny_today
    no
  • est31_seen_a_bunny_today
    it was not
  • KiChjang
    Manishearth, new version isn't pushed
  • KiChjang
    published*
  • est31_seen_a_bunny_today
    there is no new version in git nor in crates.io
  • est31_seen_a_bunny_today
  • est31_seen_a_bunny_today
    latest one according to this is 0.5.0, same on crates.io
  • est31_seen_a_bunny_today
    !crate urlencoded
  • rustbot
    urlencoded (0.5.0) - Decoding middleware for url-encoded data. For use with Iron. -> crates.io/crates/urlencoded <docs.rs/urlencoded>
  • Manishearth
    oh, I see
  • Manishearth
    my bad
  • Manishearth
    will fix
  • est31_seen_a_bunny_today
    so I need 0.6.0 or 0.5.1 or w/e
  • est31_seen_a_bunny_today
    thanx
  • tigercosmos
  • tigercosmos
    script_layout_interface/rpc.rs only has function name
  • fabrice
  • tigercosmos
    in that function
  • tigercosmos
    client_rect: self.0.lock().unwrap().scroll_area_response
  • tigercosmos
    I can't find "scroll_area_response"
  • fabrice
  • tigercosmos
    I know that
  • tigercosmos
  • tigercosmos
    pub scroll_area_response: Rect<i32>
  • tigercosmos
    umm.. I am wondering how "scroll_area_response" get value
  • tigercosmos
    In fact, I am doing #19280. Maybe my direction is wrong.
  • crowbot
    Issue #19280: element.clientHeight & element.scrollHeight incomplete implement - servo/servo #19280
  • tigercosmos
    But I think "scrollHeight" get a wrong scroll area, and then I find "scroll_area_response"
  • ghservo
    [servo] KiChjang opened issue #19283: Implement EventTarget constructor git.io/vFHud
  • ghservo
    [servo] paulrouget opened issue #19284: Add a method to Servo to clean the history git.io/vFHuN
  • ghservo
    [servo] eddyb opened pull request #19285: Update expected stylo sizes for rust-lang/rust#45225. (master...squash) git.io/vFHwa
  • nox
    eddyb: Nice.
  • matthiaskrgr
    hm interesting
  • matthiaskrgr
    I guess I'm going to make a ticket and see what happens
  • matthiaskrgr
    maybe it detects my OS wrongly
  • ghservo
    [servo] matthiaskrgr opened issue #19286: build failure: task_info on fedora 25: missing header mach/mach_init.h git.io/vFHPw
  • Mateon1
    Did I seriously just hit a parser bug?
  • Mateon1
    assertion failed: c.is_some() (thread ScriptThread PipelineId { namespace_id: PipelineNamespaceId(0), index: PipelineIndex(NonZero(NonZero(1))) }, at .cargo/registry/src/github.com-1ecc6299db9ec823/html5ever-0.21.0/src/tokenizer/mod.rs:555)
  • amosbird
    Hello
  • amosbird
    is there a lua binding for servo?
  • Mateon1
    Already reported: servo/html5ever #305
  • crowbot
    Issue #305: Crash when parsing an argument value that is `\r\n` - servo/html5ever #305
  • ghservo
    [servo] mateon1 opened issue #19287: assertion failed: !self.nodes.contains_key(&id) git.io/vFHMs
  • Mateon1
    ^ The <details> element seems extremely buggy in Servo
  • Mateon1
    Even more buggy than flex and tables.
  • ghservo
    [servo] m-novikov opened pull request #19288: Implement EventTarget constructor (master...impl-eventtarget-constructor) git.io/vFHQn
  • ghservo
    [servo] Brooooooklyn opened issue #19289: get some trouble with compile canvas components git.io/vFHQC
  • canaltinova
    emilio: hey, yt?
  • emilio
    canaltinova: kinda, yeah
  • emilio
    Mateon1: that sounds... Believable
  • canaltinova
    emilio: I just want to know your opinions on the initial_value method naming. We cannot name it false since rust doesn't allow that. and false_ seems bad. what should we do? :D
  • canaltinova
    NAMING THINGS IS HARD!
  • ghservo
    [servo] CYBAI opened issue #19290: Move font-feature-settings outside of mako. git.io/vFHFu
  • ghservo
    [ipc-channel] antrik opened pull request #181: cleanup: Use `RangeFrom` rather than custom `Incrementor` (master...cleanup-custom-incrementor) git.io/vFHAF
  • » KiChjang suspects canaltinova is back because they see that i am catching up in the number of commits to the servo repo
  • canaltinova
    KiChjang: heh :D
  • canaltinova
    KiChjang: btw, I'm still not sure about that method naming :)
  • KiChjang
    you can do whichever really
  • KiChjang
    i don't have a preference
  • canaltinova
    ugh, I don't like choosing a name :(
  • emilio
    canaltinova: sorry, ran out of battery :(
  • emilio
    canaltinova: what about `no` or `zero`?
  • canaltinova
    emilio: np. hm, I don't know. Actually, I just r=you `false_value` :)
  • canaltinova
    emilio: zero is probably a bit misguiding but maybe `no`?
  • emilio
    canaltinova: sounds ok... Zero is what the user would write in the CSS right? Doesn't sound that misguiding if you account for that
  • emilio
    canaltinova: anyway sounds fine
  • canaltinova
    emilio: oh, right
  • ghservo
    [webrender] glennw closed issue #1854: The contrast() filter does not deal with premultiplied alpha correctly git.io/vdKwz
  • ghservo
    [webrender] glennw closed pull request #2053: Remove AlphaBatchTask, and introduce start of raster mode. (master...remove-alpha-task2) git.io/vFylZ
  • ghservo
    [servo] KiChjang opened issue #19291: Intermittent crash of /css/css-transforms/group/svg-transform-nested-019.html git.io/vFQUj
  • ghservo
    [webrender] glennw opened pull request #2060: Fix build breakage with current rustc: (master...fix-build) git.io/vFQTq
  • KiChjang
    does anybody know what the [Abstract] extended WebIDL attribute does?
  • gw
    Gankro: I was going to ask if anyone knew if that was a reasonable fix before getting an r+ :)
  • gw
    Gankro: I don't understand - my rustc version hasn't changed, and as far as I know, no dependencies should have changed since the Cargo.lock is the same??
  • Gankro
    gw: it's reasonable in the sense that we don't need panic=abort to dev, it's just good for profiling
  • gw
    Gankro: ok, so it won't break the gecko build or anything like that?
  • Gankro
    lemme check some stuff
  • gw
    Gankro: Looks like this is the last PR thaat got merged servo/webrender #2032. It does update dependencies, so I guess that's what caused it. I don't understand how it got through CI though.... :/
  • crowbot
    PR #2032: Add program_binary support - servo/webrender #2032
  • Gankro
    We should be able to compile fine with panic=unwind deps
  • gw
    Gankro: ok, that seems like a reasonable work around for now then. I still have no idea how it got broken on master when that last PR passed CI OK...?
  • Gankro
    gw: is it only release builds that are busted?
  • Gankro
    because we might not CI that..?
  • gw
    Gankro: yea. But they do get tested on CI
  • gw
    Gankro: This is one of the release build logs - travis-ci.org/servo/webrender/jobs/303422292 - it runs the reftests in release mode... veeeery strange
  • Gankro
    gw: can you run `cargo clean`?
  • gw
    Gankro: test if that fixes it without the Cargo.toml change, you mean?
  • Gankro
    gw: yeah
  • ghservo
    [webrender] glennw closed pull request #2060: Fix build breakage with current rustc: (master...fix-build) git.io/vFQTq
  • Gankro
    gw: yeah I reproduced it locally too, but after a cargo clean it seems fine..?
  • gw
    Gankro: just building release now after a clean - it does look promising so far though
  • gw
    Gankro: That would explain it working on CI, if it's a cargo clean issue
  • Gankro
    It did trigger a slight change in my Cargo.lock that I don't full understand
  • Gankro
    changed wrench from [root] to [[package]]
  • gw
    O.o
  • ghservo
    [servo] bors-servo closed pull request #19279: style: Move -moz-force-broken-image-icon out of mako (master...force-broken-image) git.io/vF9N3
  • gw
    Gankro: no cargo.lock change here, but it does build successfully after a cargo clean.
  • gw
    \o/
  • Gankro
    *shrug* compiler demons
  • gw
    maybe rustc just doesn't like early monday mornings
  • Gankro
    First time I've ever seen a clean matter with cargo tho. Honestly wasn't even sure it was a command!
  • » gw shrugs
  • gw
    Gankro: thanks anyway, now I can move onto more interesting things :)
  • Gankro
    hooray
  • Gankro
    gw: oh the Cargo.lock change might be a nightly thing
  • gw
    ah
  • Gankro
    (tried nightly and stable to make sure it worked on both)
  • Gankro
    gw: at one point if you get a PR changing that, it should be fine. Only breaks compat with <= rust 1.11
  • Gankro
    We're on like 1.21 stable
  • gw
    Gankro: ok, thanks
  • ghservo
    [servo] jdm closed issue #19291: Intermittent crash of /css/css-transforms/group/svg-transform-nested-019.html git.io/vFQUj
  • Mateon1
    This is odd, ./mach is leaving zombie processes under heavy system load, and even a wrapping timeout(1) doesn't kill it
  • Mateon1
    It must be manually killed -9
  • Mateon1
    Note: timeout(1) SHOULD send kill -9 to the child process, not sure why ./mach isn't dying, though
  • cpearce
    gw: I have video frames showing onscreen in a test app. :) making horrendous number of unnecessary frame copies, but at least it's showing video frames on screen. :D
  • gw
    cpearce: neat!
  • ghservo
    [webrender] mstange opened issue #2061: Very large box shadows cause rendering bugs git.io/vFQYB
  • ghservo
    [webrender] bors-servo merged auto into master: git.io/vFQY0