• GitHubPS
    [pageshot] dannycoates commented on issue #2422: Nice catch @niharikak101 :)... git.io/vydpo
  • GitHubPS
    [pageshot] garbados commented on issue #2404: OK, I restored `shared/shot.js` to match the version on master, and modified `makeUuid.js` to use getRandomValues with the pre-existing 'xxxxx...'.replace approach. How's it look? git.io/vyFU6
  • GitHubPS
    [pageshot] g-k commented on issue #2301: ulfr pointed out this blog post on idat chunks too: idontplaydarts.com/2012/06/encoding-web-shells-in-png-idat-chunks git.io/vyFhD
  • GitHubPS
    [pageshot] g-k commented on issue #2219: +1 ... git.io/vyFj0
  • GitHubPS
    [pageshot] g-k opened issue #2423: Add `object-src 'none'` to CSP to disable plugins git.io/vybv6
  • GitHubPS
    [pageshot] g-k opened issue #2424: Remove unsafe-inline style-src from CSP git.io/vybJZ
  • GitHubPS
    [pageshot] g-k opened issue #2425: Add frame-ancestors 'none' to CSP git.io/vybJH
  • GitHubPS
    [pageshot] g-k opened issue #2426: Remove undefined img-src when contentOrigin isn't set git.io/vybTN
  • GitHubPS
    [pageshot] g-k opened issue #2427: Add HPKP header git.io/vybL2
  • GitHubPS
    [pageshot] g-k opened issue #2428: POST /timing returns 500 git.io/vybtM
  • GitHubPS
    [pageshot] SoftVision-CosminMuntean opened issue #2429: Page Shot button no longer redirects you to the "My Shots" page if it's clicked from Activity Stream New Tab git.io/vybYA
  • GitHubPS
    [pageshot] g-k opened issue #2430: Use yarn for package management git.io/vyb3i
  • ianbicking
  • pauloiegasSV
    thanks ! :)
  • GitHubPS
    [pageshot] g-k opened issue #2431: Set regex input matcher lengths git.io/vybEs
  • GitHubPS
    [pageshot] g-k opened pull request #2432: readme: Add note about supported firefoxes for --setup-profile (master...add-readme-setup-profile-note) git.io/vybzX
  • GitHubPS
    [pageshot] g-k commented on issue #2431: These are implicitly bound by the max upload size, but we can be stricter. git.io/vyb2P
  • GitHubPS
    [pageshot] wresuolc commented on issue #2429: @dannycoates has a PR that might fix this git.io/vybXU
  • GitHubPS
    [pageshot] wresuolc commented on issue #2428: Let's remove /timing git.io/vybXO
  • GitHubPS
    [pageshot] ckprice commented on issue #2424: Ian thinks we had a reason why this is here. Nice to have == Next git.io/vyb1J
  • GitHubPS
    [pageshot] ckprice commented on issue #2421: Don't think we can do, but we could ask in #team-addons git.io/vyb1C
  • GitHubPS
    [pageshot] ckprice commented on issue #2420: Ian noted that having Raven run in the high privileged could be a security risk. git.io/vyb1S
  • GitHubPS
    [pageshot] johngruen commented on issue #2418: since we're doing this, could we set default search to DDG and about:newtab to the blank screen? git.io/vybMe
  • GitHubPS
    [pageshot] ckprice commented on issue #2417: @flodolo any advice on how to get this going? Is there pseudo locale support we can use for WE's? git.io/vybMJ
  • GitHubPS
    [pageshot] flodolo commented on issue #2417: Unfortunately I don't think we have anything for this (in general). ... git.io/vybMX
  • GitHubPS
    [pageshot] ianb commented on issue #2399: This is done and confirmed git.io/vybD6
  • GitHubPS
    [pageshot] ianb commented on issue #2398: I'm pretty sure this is done, but it was from a long time ago and double-checking this would be good. git.io/vybDS
  • _6a68
    MBP is about to die :-(
  • _6a68
    Thanks everybody! Sorry that one went over a bit
  • ianbicking
  • GitHubPS
    [pageshot] ianb opened issue #2433: Some errors in auth.js should map to LOGIN_ERROR git.io/vybQX
  • GitHubPS
    [pageshot] ianb opened issue #2434: Confirm error messages in senderror exist git.io/vybQp
  • GitHubPS
    [pageshot] ianb pushed 2 new commits to master: git.io/vyb7f
  • GitHubPS
    pageshot/master 489ae40 Greg Guthe: readme: Add note about supported firefoxes for --setup-profile
  • GitHubPS
    pageshot/master 93e8344 Ian Bicking: Merge pull request #2432 from g-k/add-readme-setup-profile-note...
  • ianbicking
    dcoates: I’ll leave mozilla-services/pageshot #2422 for you to review/merge?
  • dcoates
    👍
  • ianbicking
    dcoates: and you said mozilla-services/pageshot #2368 is ready for review?
  • dcoates
    yeah, but i can add the activity stream part to it also
  • ianbicking
    dcoates: ok, sure, just re-ping me then?
  • dcoates
    ok
  • GitHubPS
    [pageshot] dannycoates opened issue #2435: Error when trying to screenshot testpilot.firefox.com git.io/vybA1
  • dcoates
    ianbicking: #2368 is ready again
  • GitHubPS
    [pageshot] pdehaan commented on issue #2380: > Is there any way to map shortlog names to GitHub usernames?... git.io/vybxT
  • GitHubPS
    [pageshot] ianb commented on pull request #2368 4caf735: There might be a whitelist of WebExtension schemes, but I don't know what it is exactly git.io/vybxj
  • _6a68
    ianbicking: should I just merge mozilla-services/pageshot #2397, or did you want to take another look?
  • GitHubPS
    [pageshot] ianb closed pull request #2397: Observe prefs and control webextension startup and shutdown via a pref (master...enabling-pref) git.io/vyyK4
  • GitHubPS
    [pageshot] ianb pushed 1 new commit to master: git.io/vyNeU
  • GitHubPS
    pageshot/master cd33c8a Ian Bicking: Merge pull request #2397 from mozilla-services/enabling-pref...
  • GitHubPS
    [pageshot] ianb closed issue #2370: Remove deviceInfo pref after migrating git.io/vyPWE
  • GitHubPS
    [pageshot] ianb deleted enabling-pref at b28d687: git.io/vyNek
  • ianbicking
    it is so done
  • _6a68
    ^_^ thx
  • GitHubPS
    [pageshot] 6a68 commented on pull request #2413 c53d27c: I guess this is okay: it's not an accurate check for objecthood, but it's unlikely that `null`, an array, or some oddball object like `Math` would ever get passed in here. git.io/vyNq1
  • GitHubPS
    [pageshot] 6a68 closed issue #2220: Use site-helper to login on page visit git.io/vyUEk
  • GitHubPS
    [pageshot] 6a68 deleted sitehelper-login at c53d27c: git.io/vyNqS
  • GitHubPS
    [pageshot] 6a68 commented on issue #2205: I think we have the addon part of localization completely planned out at this point, so I'm going to remove the 'beta blocker' label and tweak the title. git.io/vyNmO
  • 557A6UHSP
    [pageshot] 6a68 closed issue #2205: Plan server localization git.io/vDjmS
  • 203A6TJMS
    [pageshot] 6a68 commented on issue #2205: Hmm. Actually, we have a plan for server localization, too. So, I'm going to go ahead and close this. git.io/vyNmW
  • GitHubPS
    [pageshot] ianb commented on pull request #2413 c53d27c: The type coercion here is a little sloppy, but objects in particular (as opposed to strings and numbers and null) trigger permission problems when transferring them between the add-on and content. I forgot about null==object though, that's an annoying case, but at least undefined (as when the argument isn't given) will be left alone. git.io/vyNYv
  • ianbicking
    _6a68: re: auth, pages aren’t entirely public, when you are the owner you’ll see a delete button and be able to change the expiration, etc.
  • _6a68
    ah
  • GitHubPS
    [pageshot] ianb commented on issue #2428: Note the `/timing` route is in `server/src/server.js` git.io/vyNYy
  • GitHubPS
    [pageshot] 6a68 commented on issue #2435: Content scripts are disabled on Mozilla sites that are `mozAddonManager` whitelisted. See bugzil.la/1310082 for related discussion.... git.io/vyN3f
  • GitHubPS
    [pageshot] 6a68 commented on issue #2295: Got an update on this issue from @johngruen today: looking at next week for final strings. We should be good to start localization after that. git.io/vyN3V
  • GitHubPS
    [pageshot] johngruen commented on issue #2295: I should have an initial PR tomorrow git.io/vyN3y
  • GitHubPS
    [pageshot] ianb commented on issue #2435: Probably we should disable Page Shot on these sites.... git.io/vyNsc
  • GitHubPS
    [pageshot] 6a68 commented on issue #2435: Hmm. We should be able to detect such pages via `'mozAddonManager' in navigator`. If it's true, then bail. git.io/vyNsQ
  • GitHubPS
    [pageshot] ianb commented on issue #2435: I don't believe we can access navigator from the background page. git.io/vyNGL
  • GitHubPS
    [pageshot] 6a68 commented on issue #2419: @ianb Hmm, the notification looks a bit odd:... git.io/vyNGA
  • GitHubPS
    [pageshot] ianb commented on issue #2419: I suppose we could strip `/^error:\s+/i` from the message git.io/vyNZL
  • GitHubPS
    [pageshot] ianb created pageshot-classname-removal (+22 new commits): git.io/vyNBM
  • GitHubPS
    pageshot/pageshot-classname-removal 2c1e7a9 Ian Bicking: Change code that reads className to classList...
  • GitHubPS
    pageshot/pageshot-classname-removal 0a5e773 Ian Bicking: Remove pageshot-saver from isHeader check...
  • GitHubPS
    pageshot/pageshot-classname-removal 586da24 Ian Bicking: Remove references to myshots-reminder, which was removed
  • GitHubPS
    [pageshot] ianb pushed 1 new commit to pageshot-classname-removal: git.io/vyNRa
  • GitHubPS
    pageshot/pageshot-classname-removal 0c78069 Ian Bicking: Rename goto-pageshot metric to goto-homepage...
  • GitHubPS
    [pageshot] ianb opened pull request #2436: Pageshot classname removal (master...pageshot-classname-removal) git.io/vyNRM
  • travis-ci
    The build passed.: mozilla-services/pageshot#2753 (pageshot-classname-removal - 0716727 : Ian Bicking) travis-ci.org/mozilla-services/pageshot/builds/213173032
  • travis-ci
    The build passed.: mozilla-services/pageshot#2754 (pageshot-classname-removal - 0c78069 : Ian Bicking) travis-ci.org/mozilla-services/pageshot/builds/213174474
  • GitHubPS
    [pageshot] niharikak101 commented on issue #2422: Hey @dannycoates thank you for breaking it down so nicely! :)... git.io/vyNu8
  • GitHubPS
    [pageshot] g-k opened issue #2437: don't redirect to data: and javascript: protocols/schemes git.io/vyNzB
  • GitHubPS
    [pageshot] 6a68 commented on issue #2435: Good point!... git.io/vyNrK
  • GitHubPS
    [pageshot] 6a68 commented on issue #2419: I'm seeing that busted notification in a few other spots, so I"ll just file a bug about it and finish this review git.io/vyNr9
  • GitHubPS
    [pageshot] g-k opened issue #2438: validate request body objects before parsing as JSON git.io/vyNKI
  • GitHubPS
    [pageshot] dannycoates commented on issue #2422: > error handling of the text should probably be done before the function is called... git.io/vyNKD
  • GitHubPS
    [pageshot] dannycoates commented on issue #2422: > error handling of the text should probably be done before the function is called... git.io/vyNKD
  • GitHubPS
    [pageshot] 6a68 created fix-notifications (+1 new commit): git.io/vyN6g
  • GitHubPS
    pageshot/fix-notifications 3bf2fe9 Jared Hirsch: Always pass empty strings, not null, to notifications API
  • GitHubPS
    [pageshot] 6a68 force-pushed fix-notifications from 3bf2fe9 to 9d739fa: git.io/vyN6i
  • GitHubPS
    pageshot/fix-notifications 9d739fa Jared Hirsch: Always pass empty strings, not null, to notifications API
  • GitHubPS
    [pageshot] ianb opened issue #2439: Create email address to replace pageshot-report git.io/vyNif
  • travis-ci
    The build passed.: mozilla-services/pageshot#2756 (fix-notifications - 3bf2fe9 : Jared Hirsch) travis-ci.org/mozilla-services/pageshot/builds/213208830
  • GitHubPS
    [pageshot] 6a68 force-pushed fix-notifications from 9d739fa to 4f70b6e: git.io/vyN6i
  • GitHubPS
    pageshot/fix-notifications 4f70b6e Jared Hirsch: Always pass empty strings, not null, to notifications API
  • travis-ci
    The build passed.: mozilla-services/pageshot#2757 (fix-notifications - 9d739fa : Jared Hirsch) travis-ci.org/mozilla-services/pageshot/builds/213209155
  • GitHubPS
    [pageshot] 6a68 opened pull request #2440: Pass empty strings, not null, to notifications API (master...fix-notifications) git.io/vyNip
  • GitHubPS
    [pageshot] zelitomas opened issue #2441: UI - Expiration time can't be changed if URL of screenshoted page is too long git.io/vyNPT
  • GitHubPS
    [pageshot] 6a68 closed pull request #2419: Better server unavailable error (master...better-server-unavailable-error) git.io/vy7de
  • GitHubPS
    [pageshot] 6a68 closed issue #2305: Confirm errors when server isn't available git.io/vyEsK
  • GitHubPS
    [pageshot] 6a68 deleted better-server-unavailable-error at dd75b42: git.io/vyNXL
  • GitHubPS
    [pageshot] dannycoates closed pull request #2440: Pass empty strings, not null, to notifications API (master...fix-notifications) git.io/vyNip
  • GitHubPS
    [pageshot] 6a68 deleted fix-notifications at 4f70b6e: git.io/vyNX1
  • GitHubPS
    [pageshot] ianb pushed 12 new commits to pageshot-classname-removal: git.io/vyNXy
  • GitHubPS
    pageshot/pageshot-classname-removal 80afe21 Ian Bicking: Remove help page that wasn't linked to
  • GitHubPS
    pageshot/pageshot-classname-removal e96b86e Ian Bicking: Rename readable/text versions of 'Page Shot' to be 'Firefox Screenshots' or 'Screenshots'
  • GitHubPS
    pageshot/pageshot-classname-removal e54b27b Ian Bicking: Rename miscellaneous small instances of 'pageshot'
  • ianbicking
    _6a68: oh, just noticed you claimed that for review. I will refrain from pushing more, though that’s most of what I planned
  • ianbicking
    until we rename the repo and id
  • _6a68
    cool, do we need to wait to rename the repo?
  • _6a68
    and does id refer to the bootstrapped addon id in install.rdf, I'm guessing?
  • ianbicking
    _6a68: I want to be sure we rename some public locations once we rename the repo, but that’s it
  • ianbicking
    _6a68: and yes, the id in install.rdf, and there’s a couple places things are derived from that name
  • _6a68
    ah. public mowiki pages, stuff like that?
  • ianbicking
    _6a68: yeah, at least look around some, though it’ll redirect so it’s not that big a deal
  • _6a68
    👍 reviewing and testing that PR now
  • circleci-bot
    Failed: ianb's build (#150; push) in mozilla-services/pageshot (pageshot-classname-removal) -- circleci.com/gh/mozilla-services/pa…&utm_medium=referral&utm_source=irc
  • travis-ci
    The build was broken.: mozilla-services/pageshot#2762 (pageshot-classname-removal - 2bb7b84 : Ian Bicking) travis-ci.org/mozilla-services/pageshot/builds/213216910