-
github-bot
[missioncontrol] wlach opened pull request #271: Show version in main view (fixes #270) (master...show-version-in-main-view)
git.io/vp5mo
-
github-bot
[missioncontrol] wlach opened pull request #272: Don't show decimals in percent change if change > 10% (master...show-decimal-threshold-main-view)
git.io/vp5YV
-
github-bot
[missioncontrol] wlach opened pull request #273: Handle esr builds (fixes #269) (master...handle-esr)
git.io/vp53u
-
github-bot
[missioncontrol] wlach closed pull request #272: Don't show decimals in percent change if change > 10% (master...show-decimal-threshold-main-view)
git.io/vp5YV
-
cloudops-ansible
data/missioncontrol build #217 deployed to dev
-
github-bot
[missioncontrol] wlach closed pull request #273: Handle esr builds (fixes #269) (master...handle-esr)
git.io/vp53u
-
github-bot
[missioncontrol] wlach closed pull request #271: Show version in main view (fixes #270) (master...show-version-in-main-view)
git.io/vp5mo
-
cloudops-ansible
data/missioncontrol build #218 deployed to dev
-
wlach
-
wlach
it looks like we're not seeing any data in fennec beta in mission control because we're not processing the correct display version
-
frank
wlach: they do not have displayVersion
-
wlach
frank: is that something we could add?
-
wlach
frustrating that I only noticed this now :/
-
frank
I'm weakly opposed to adding things to the core ping for specific products
-
frank
since it's used across many mobile applications
-
cloudops-ansible
data/missioncontrol build #219 deployed to dev
-
wlach
frank: I don't think displayVersion is really product specific
-
wlach
in any case it's either we fix this in *some* way or we decide that mission control won't show beta information for fennec
-
frank
wlach: is displayVersion a thing for any application with a version?
-
frank
I've never heard of it outside Fx
-
frank
but yes, we need it for mission control
-
wlach
frank: I have no idea why we use it in firefox, it's incredibly confusing
-
wlach
it has probably wasted about 30 hours of my life by now, if not more
-
frank
wlach: I know :( okay well let's do whatever is easier for you right now
-
frank
mobile telemetry is in flux so we can change it later if it comes to that
-
wlach
frank: easiest and most straightforward is probably to add the field to the ping, then make telemetry-streaming aware of it if present.
-
frank
yup that's reasonable
-
frank
wlach: want to file a bug?
-
wlach
we shouldn't assume that it's present of course
-
frank
it's going to have to ride the trains
-
frank
and people are hesitant to make Fennec changes right now as well :/
-
wlach
of course adding it to the ping probably means altering the schema and a pile of other dependent stuff
-
wlach
I think this is trivial enough that it won't be a big deal
-
wlach
we can probably even uplift it to beta at this point in the cycle
-
wlach
frank: I will file a bug
-
frank
yeah looking at TelemetryCorePingBuilder.java it should be easy, assuming it's available _somewhere_
-
wlach
I can probably fix it
-
frank
wlach: I was thinking as much, but was not going to say as much :)
-
wlach
will take care of that after my 1:1 with our team's newest member
-
frank
awesome
-
frank
Arkadiusz or I can handle the remaining changes pipeline side then
-
wlach
cool, the telemetry-streaming changes should be absolutely trivial
-
frank
only other one is the schema, we should add it, though it's optional
-
wlach
frank: thinking about it more, I think displayVersion would be useful to other applications which want to create a confusing distinction between their actual version number and the one they display to users
-
wlach
;)
-
frank
wlach: oh good point! I'll put it in the 2018 Mobile plans :)
-
wlach
frank: I have an idea
-
wlach
frank: how about we just submit the displayVersion as the appVersion in Fennec only?
-
wlach
no weird and confusing new fields that way
-
frank
wlach: I would recommend keeping that field as-is, it's already in use by people
-
frank
adding a new field specific for Fennec sucks but it's life, in the future mobile world we'd add it to the mobile-metrics ping as a scalar
-
whd
wlach: you're going to get an email about a new newrelic account, apparently I was supposed to migrate to this account last year but never did
-
whd
and am doing so now ;)
-
wlach
frank: are people depending on getting a version string like 60.0 instead of 60.0b4?
-
wlach
frank: for nightly we would already be submitting 60.0a1
-
frank
normally it's just a GROUP BY
-
frank
so even though it's a weird string it's still the same across the release
-
wlach
ok
-
wlach
sounds like the right thing is to modify the ping :(
-
frank
wlach: sadly, it is. A brave new world awaits in the next few quarters though, so despair not
-
wlach
how are we going to get around this problem? by not shipping fennec anymore? :D
-
frank
wlach: not sure if sarcasm, Fennec is being totally replaced :)
-
frank
no but the mobile-metrics ping will allow different metrics for different projects
-
frank
so we'd add a scalar to Fennec that has the displayVersion
-
wlach
frank: oh I see, ok
-
wlach
but not shipping fennec should have the same benefit :)
-
frank
"not shipping" would solve a lot of problems ;)
-
wlach
whd: got the email, thanks!
-
whd
np
-
github-bot
[missioncontrol] wlach opened pull request #274: Round percents if >10% in both upward and downward directions (master...fix-rounding-percents-for-reals)
git.io/vp5Xw
-
github-bot
[missioncontrol] wlach closed pull request #274: Round percents if >10% in both upward and downward directions (master...fix-rounding-percents-for-reals)
git.io/vp5Xw
-
cloudops-ansible
data/missioncontrol build #220 deployed to dev
-
wlach
standups: posted patch to add display version to core pings, so we can normalize crash counts on fennec beta
bugzilla.mozilla.org/1461772
-
standups
Ok, submitted #57342 for
standu.ps/user/wlach
-
firebot
Bug 1461772 — NEW, wlachance⊙mc — Fennec core pings do not contain enough information to distinguish betas
-
frank
wlach++