frank: do you remember if core pings had/have a display version? github.com/mozilla/telemetry-stream…treaming/ErrorAggregator.scala#L198

it looks like we're not seeing any data in fennec beta in mission control because we're not processing the correct display version

wlach: they do not have displayVersion

frank: is that something we could add?

frustrating that I only noticed this now :/

I'm weakly opposed to adding things to the core ping for specific products

since it's used across many mobile applications

frank: I don't think displayVersion is really product specific

in any case it's either we fix this in *some* way or we decide that mission control won't show beta information for fennec

wlach: is displayVersion a thing for any application with a version?

I've never heard of it outside Fx

but yes, we need it for mission control

frank: I have no idea why we use it in firefox, it's incredibly confusing

it has probably wasted about 30 hours of my life by now, if not more

wlach: I know :( okay well let's do whatever is easier for you right now

mobile telemetry is in flux so we can change it later if it comes to that

frank: easiest and most straightforward is probably to add the field to the ping, then make telemetry-streaming aware of it if present.

yup that's reasonable

wlach: want to file a bug?

we shouldn't assume that it's present of course

it's going to have to ride the trains

and people are hesitant to make Fennec changes right now as well :/

of course adding it to the ping probably means altering the schema and a pile of other dependent stuff

I think this is trivial enough that it won't be a big deal

we can probably even uplift it to beta at this point in the cycle

frank: I will file a bug

yeah looking at TelemetryCorePingBuilder.java it should be easy, assuming it's available _somewhere_

I can probably fix it

wlach: I was thinking as much, but was not going to say as much :)

will take care of that after my 1:1 with our team's newest member

awesome

Arkadiusz or I can handle the remaining changes pipeline side then

cool, the telemetry-streaming changes should be absolutely trivial

only other one is the schema, we should add it, though it's optional

frank: thinking about it more, I think displayVersion would be useful to other applications which want to create a confusing distinction between their actual version number and the one they display to users

;)

wlach: oh good point! I'll put it in the 2018 Mobile plans :)

frank: I have an idea

frank: how about we just submit the displayVersion as the appVersion in Fennec only?

no weird and confusing new fields that way

wlach: I would recommend keeping that field as-is, it's already in use by people

adding a new field specific for Fennec sucks but it's life, in the future mobile world we'd add it to the mobile-metrics ping as a scalar

wlach: you're going to get an email about a new newrelic account, apparently I was supposed to migrate to this account last year but never did

and am doing so now ;)

frank: are people depending on getting a version string like 60.0 instead of 60.0b4?

frank: for nightly we would already be submitting 60.0a1

normally it's just a GROUP BY

so even though it's a weird string it's still the same across the release

ok

sounds like the right thing is to modify the ping :(

wlach: sadly, it is. A brave new world awaits in the next few quarters though, so despair not

how are we going to get around this problem? by not shipping fennec anymore? :D

wlach: not sure if sarcasm, Fennec is being totally replaced :)

no but the mobile-metrics ping will allow different metrics for different projects

so we'd add a scalar to Fennec that has the displayVersion

frank: oh I see, ok

but not shipping fennec should have the same benefit :)

"not shipping" would solve a lot of problems ;)

whd: got the email, thanks!

np

standups: posted patch to add display version to core pings, so we can normalize crash counts on fennec beta bugzilla.mozilla.org/1461772

wlach++