• julienw
    did we receive a spam from jlast's twitter account, via fitzgen AT mozilla.com forwarding automatically to fx-devtools AT mozilla.com ?
  • ntim
    rickychien: I'm looking at bug 1356872, and I was wondering whether you had some code style comments
  • firebot
    bugzil.la/1356872 — NEW, vkatsikaros⊙gmail.com — Hard to distinguish IP from Port in IPv6 address
  • rickychien
    ntim: LGTM
  • rickychien
    ntim: with some comments
  • [R]
    Let's Google That Man?
  • nchevobbe
    [R]: Looks Good To Me
  • [R]
    Ah, thanks
  • nchevobbe
    But yours was nice too :)
  • [R]
    :p
  • nchevobbe
    julienw: ping
  • julienw
    nchevobbe, yep
  • nchevobbe
    julienw: Hello ! I'm trying to make sense of a profile perf-html.io/public/d2e1bb0dbc15859…sOnly&range=3.2805_12.6238&thread=0
  • nchevobbe
    julienw: I don't understand the 2.5s gap I see starting at 4s
  • nchevobbe
    there doesn't seems to be any information about it
  • nchevobbe
    except platform things I don't really understand
  • julienw
    nchevobbe, looking
  • julienw
    nchevobbe, I think you don't have enough data
  • julienw
    nchevobbe, in the addon settings you can increase the buffer size
  • julienw
    nchevobbe, try something like 90MB instead of the default 9
  • sole
    julienw: "9mb should be enough for everybody"... 😂
  • nchevobbe
    i was already at 60 i think
  • nchevobbe
    let me try with more
  • nchevobbe
    still no luck
  • nchevobbe
    🤔
  • julienw
    nchevobbe, show me the result please ?
  • nchevobbe
    julienw: sure perfht.ml/2pv8KTx
  • nchevobbe
    I think there's something going on with cached messages, but can't really tell
  • julienw
    nchevobbe, what are you profiling ?
  • julienw
    because it's indeed weird :)
  • nchevobbe
    console opening with 2000 messages in the cache
  • julienw
    nchevobbe, and what did you use as message this time ?
  • julienw
    I mean, as buffer size
  • nchevobbe
    90MB
  • julienw
    nchevobbe, try 180MB ?
  • julienw
    :)
  • julienw
    just to see if this changes anything
  • nchevobbe
    it's really the display of the cached messages that does that, I delayed it for a bit and could see the same gap, even if the console was already opened
  • nchevobbe
    sure :)
  • nchevobbe
  • julienw
    nchevobbe, just checking, have you tried to restart the addon (like stop/start the profile) or even restart nightly after changing the settting ?
  • julienw
    I'm not convinced it changes it on the run
  • nchevobbe
    yes, i did
  • jdescottes
    nchevobbe: if you uncheck "javascript only" you can see some profiling information
  • julienw
    yep
  • julienw
    but still not in the main thread
  • julienw
    neither the compositor
  • nchevobbe
    yeah, but I can't get much sense of it
  • julienw
    this is really strange
  • julienw
    IMO the important part is the main thread, that's where everything happens with the devtools
  • julienw
    trying to "invert" the profile, this takes a looooot of time
  • julienw
    nchevobbe, mmm looks like you shared the profile before it was symbolicated
  • julienw
    so we don't see gecko's function names
  • nchevobbe
    oh
  • julienw
    I see render() in frame.js takes a lot of time
  • julienw
    200ms
  • nchevobbe
    yeah, this one is likely to be shorter with the new reps bundle
  • julienw
    also in message.js
  • nchevobbe
    but it's really the time where there isn't any calls in the profiler that I find strange
  • nchevobbe
    julienw: if a setTimeout call is cancelled, would it appear in perf-html ?
  • nchevobbe
    I'm wondering if there isn't some sort of throttling on react or redux side that would explain this long hang
  • julienw
    nchevobbe, if it's canceled it's not run, right ? :)
  • nchevobbe
    julienw: right :)
  • pbro
    There's a "travelling to the US" brown bag at the same time as our DevTools meeting. It will be recorded and available here: air.mozilla.org/brown-bag-q-a-trave…g-to-the-us-for-june-2017-all-hands
  • jdescottes
    dEVtOOls
  • tromey
    𝔇𝔢𝔳𝔗𝔬𝔬𝔩𝔰
  • sole
    hahaha tromey
  • jryans
    r+
  • sole
    nchevobbe: nice, a 2014 bug!
  • sole
    Vintage
  • sole
    jlast: sorry I missed a second of the conversation-if you were to enumerate properties of an object with the actor there is a thing called JSPropertyProvider that does it in the actor but it sort of does I think the same thing you're doing... looking at keys etc
  • jlast
    oh thanks sole
  • sole
    I think it's in the shared folder though... somewhere
  • jlast
    do you think it would know what was application specific and what is a "native" propety?
  • sole
    I think it does!
  • sole
  • sole
    gregtatum: so cool to see the threads side by side :D :D
  • gregtatum
    sole: thanks :)
  • nchevobbe
    sole: your tshirt looks so cool 😻
  • ochameau
    jlast: this native property story is something firebug supported at least via the DOM panel
  • ochameau
    jlast: we already discussed about this with honza in bug 1312250
  • firebot
    bugzil.la/1312250 — UNCONFIRMED, nobody⊙mozilla.org — Developer Tools DOM: Display Order
  • ochameau
    jlast: we can surely do something on the actors side of reps
  • ochameau
    jlast: we may mentor nchevobbe to tweak reps for this ;)
  • nchevobbe
    ochameau: :)
  • sole
    nchevobbe: :D
  • sole
    nchevobbe: "Didn’t say it was my first C++ patch :)" 👏🏼
  • jlast
    haha - that'd be great.
  • jlast
    We'll be adding the Object Inspector to the reps frontend, which is the new variables view
  • bgrins
    ochameau: btw there was recently a new bug filed about vview perf (bugzilla.mozilla.org/1348761) which I also forwarded onto debugger.html since Object Inspector seems to have a similar issue (devtools-html/debugger.html #2671). Unclear if it's server side or client side - my quick profiling didn't show anything from the server which made me wonder if I was missing something in the profile
  • firebot
    Bug 1348761 — NEW, nobody⊙mozilla.org — Console hangs the browser when attempting to view a printed object
  • bgrins
    I think you have more knowledge / experience with perf in the object actor land.. if you had a chance to take a look at perf here it would be very helpful
  • ochameau
    bgrins: ok, I'll take a look.
  • bgrins
    thanks!
  • bgrins
    it's one of these emscripten situations with a giant Module global
  • ochameau
    if the debugger isn't using old variable inspector, it is most likely not splitting properties, like what I did long time ago.
  • ochameau
    this is the only way to support inspecting such object
  • bgrins
    yeah, even vview hangs on it though so i'm not sure if it's property count that's the only problem
  • ochameau
    ok ok
  • jlast
    hmm, interesting - do you mean paginating the property list?
  • ochameau
    yes you can find some more context over bug 1270179
  • firebot
    bugzil.la/1270179 — FIXED, poirot.alex⊙gmail.com — Inspecting big typed array, typically webaudio ones freeze the browser when opening them in the vari
  • ochameau
    it was speeding up inspector window object, but I think what you did is even better.
  • mrbkap
    Hello, anyone around who knows about the service worker debugging workaround?